Update search behavior for restricted issues.#7522
Open
labkey-klum wants to merge 1 commit intorelease26.3-SNAPSHOTfrom
Open
Update search behavior for restricted issues.#7522labkey-klum wants to merge 1 commit intorelease26.3-SNAPSHOTfrom
labkey-klum wants to merge 1 commit intorelease26.3-SNAPSHOTfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Restricted issues were previously not getting indexed by the crawler because the search user did not have access to all of the issues. If the index were deleted, these issues would never reappear in the index unless they were resaved by a user with access.
This change ensures that all restricted issues can be indexed by the crawler. Additionally any restricted issues that appear in the search summary will not render any comments. Instead, a warning will be displayed to inform the user that they do not have access to that restricted issue. As was the behavior prior, clicking on the details link will generate an unauthorized exception.